Re: [PATCH] arm64: dts: exynos: Revert "Remove unneeded address space mapping for soc node"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 12, 2019 at 09:36:02AM +0200, Marek Szyprowski wrote:
> Commit ef72171b3621 ("arm64: dts: exynos: Remove unneeded address space
> mapping for soc node") changed the address and size cells in root node from
> 2 to 1, but /memory nodes for the affected boards were not updated. This
> went unnoticed on Exynos5433-based TM2(e) boards, because they use u-boot,
> which updates /memory node to the correct values. On the other hand, the
> mentioned commit broke boot on Exynos7-based Espresso board, which
> bootloader doesn't touch /memory node at all.
> 
> This patch reverts commit ef72171b3621, so Exynos5433 and Exynos7 SoCs
> again matches other ARM64 platforms with 64bit mappings in root node.
> 
> Reported-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> Fixes: ef72171b3621 ("arm64: dts: exynos: Remove unneeded address space mapping for soc node")
> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx>
> Tested-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> ---
> A few more comments:
> 
> 1. I've added 'tested-by' tag from Alim, as his original report pointed
> that reverting the offending commit fixes the boot issue.
> 
> 2. This patch applies down to v4.18.
> 
> 3. For v5.3 release, two patches:
>    - "arm64: dts: exynos: Move GPU under /soc node for  Exynos5433"
>    - "arm64: dts: exynos: Move GPU under /soc node for Exynos7"
>    has to be applied first to ensure that GPU node will have correct 'reg'
>    property (nodes under /soc still use 32bit mappings). I'm not sure if

Thanks, applied.

I tried the cc-stable-with-prerequisites syntax. It looks like this:
https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/commit/?h=next/dt64&id=bed903167ae5b5532eda5d7db26de451bd232da5

I hope it will work...

Best regards,
Krzysztof




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux for Synopsys ARC Processors]    
  • [Linux on Unisoc (RDA Micro) SoCs]     [Linux Actions SoC]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  •   Powered by Linux