On 9/20/19 13:35, Marek Szyprowski wrote: > From: Maciej Falkowski <m.falkowski@xxxxxxxxxxx> > > Convert Samsung I2S controller to newer dt-schema format. > .../devicetree/bindings/sound/samsung-i2s.txt | 84 ----------- > .../bindings/sound/samsung-i2s.yaml | 135 ++++++++++++++++++ > 2 files changed, 135 insertions(+), 84 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/samsung-i2s.txt > create mode 100644 Documentation/devicetree/bindings/sound/samsung-i2s.yaml > diff --git a/Documentation/devicetree/bindings/sound/samsung-i2s.yaml b/Documentation/devicetree/bindings/sound/samsung-i2s.yaml > new file mode 100644 > index 000000000000..20ae5da7f798 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/samsung-i2s.yaml > + clocks: > + minItems: 1 > + maxItems: 3 > + description: | > + There are following clocks available at the I2S device nodes: > + CLK_I2S_CDCLK: > + the CDCLK (CODECLKO) gate clock. > + > + CLK_I2S_RCLK_PSR: > + RCLK prescaler divider clock corresponding to the IISPSR register. > + > + CLK_I2S_RCLK_SRC: > + RCLKSRC mux clock corresponding to RCLKSRC bit in IISMOD register. Sorry for the confusion, this description refers to the supplier clocks but the clocks property refers to the consumer clocks. The I2C controller is both clock consumer and provider. I'm not sure where this description should be moved to, "#clock-cells" property might be better but is likely not the right place either. > + clock-names: > + oneOf: > + - items: > + - const: iis > + - items: > + - const: iis > + - const: i2s_opclk0 > + - items: > + - const: iis > + - const: i2s_opclk0 > + - const: i2s_opclk1 > + description: | > + "iis" is the i2s bus clock. > + For i2s1 and i2s2 - "iis", "i2s_opclk0" > + For i2s0 - "iis", "i2s_opclk0", "i2s_opclk1" > + > + "#clock-cells": > + const: 1 -- Thanks, Sylwester
