On Wed, Sep 18, 2019 at 12:59:28PM +0200, Sylwester Nawrocki wrote: > On 9/18/19 12:46, Sylwester Nawrocki wrote: > > The WM1811/WM8994/WM8958 audio CODEC DT bindings specify two optional > > clocks: "MCLK1", "MCLK2". Add code for getting those clocks in the MFD > > part of the wm8994 driver so they can be further handled in the audio > > CODEC part. > > > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> > > --- > > > > + wm8994->mclk[WM8994_MCLK1].id = "MCLK1"; > > + wm8994->mclk[WM8994_MCLK2].id = "MCLK2"; > > + > > + ret = devm_clk_bulk_get_optional(wm8994->dev, ARRAY_SIZE(wm8994->mclk), > > + wm8994->mclk); > > + if (ret != 0) > > + return ret; Would be nice to print a message here as well, make it clear what failed in the log. Apart from that minor nit: Acked-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> Thanks, Charles
