On Wed, 4 Sep 2019 at 16:39, Mark Brown <broonie@xxxxxxxxxx> wrote: > > On Wed, Sep 04, 2019 at 04:28:29PM +0200, Krzysztof Kozlowski wrote: > > On Wed, 4 Sep 2019 at 16:00, YueHaibing <yuehaibing@xxxxxxxxxx> wrote: > > > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > > > This tag does not look real... First of all where is the report? > > Second, it was reported by coccinelle. > > Reported-by should be use to give real credits. > > I think it's reasonable, it's giving credit to the automated system > they've got running coccinelle (which they do mention in their commit > logs). It doesn't really hurt anyone and lets people see their system > is finding stuff. Running internally coccinelle is already credited with commit author. The credits are coming with "From:" field. Otherwise for commits I send I could use: From: krzk ... Reported-by: www.krzk.eu Signed-off-by: krzk To me it is ridiculous. Different thing is that Reported-by is for fixing bugs or issues. There is no bug here. There is no problem solved except making the code smaller. That's not what is Reported-by for. Best regards, Krzysztof
