Re: [PATCH] arm64: dts: exynos: Propagate address/size cell change to /memory node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks Marek,
This fixes the booting issue on exyno7-espresso board.
Probably this should be CCed to -stable.

On 9/4/19 2:18 PM, Marek Szyprowski wrote:
> Commit ef72171b3621 ("arm64: dts: exynos: Remove unneeded address space
> mapping for soc node") changed the address and size cells in root node from
> 2 to 1, but /memory nodes for the affected boards were not updated. This
> went unnoticed on Exynos5433-based TM2(e) boards, because they use u-boot,
> which updates /memory node to the correct values. On the other hand, the
Yes, we don't use u-boot on this board.
> mentioned commit broke boot on Exynos7-based Espresso board, which
> bootloader doesn't touch /memory node at all.
> 
> Reported-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> Fixes: ef72171b3621 ("arm64: dts: exynos: Remove unneeded address space mapping for soc node")
> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
Feel free to add,
Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

This make exynos7 board boot again so,
Tested-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

> ---
>   arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +-
>   arch/arm64/boot/dts/exynos/exynos7-espresso.dts       | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> index db22eb56e968..e6321c8567de 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> @@ -50,7 +50,7 @@
>   
>   	memory@20000000 {
>   		device_type = "memory";
> -		reg = <0x0 0x20000000 0x0 0xc0000000>;
> +		reg = <0x20000000 0xc0000000>;
>   	};
>   
>   	gpio-keys {
> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> index 080e0f56e108..28b02830225f 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> @@ -28,7 +28,7 @@
>   
>   	memory@40000000 {
>   		device_type = "memory";
> -		reg = <0x0 0x40000000 0x0 0xC0000000>;
> +		reg = <0x40000000 0xC0000000>;
>   	};
>   
>   	usb30_vbus_reg: regulator-usb30 {
> 



[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux for Synopsys ARC Processors]    
  • [Linux on Unisoc (RDA Micro) SoCs]     [Linux Actions SoC]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  •   Powered by Linux