On Tue, 3 Sep 2019 at 19:54, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote: > > On Tue, Aug 13, 2019 at 01:55:54PM +0200, Sebastian Andrzej Siewior wrote: > > The drivers sets IRQF_ONESHOT and passes only a primary handler. The IRQ > > is masked while the primary is handler is invoked independently of > > IRQF_ONESHOT. > > With IRQF_ONESHOT the core code will not force-thread the interrupt and > > this is probably not intended. I *assume* that the original author copied > > the IRQ registration from another driver which passed a primary and > > secondary handler and removed the secondary handler but keeping the > > ONESHOT flag. > > > > Remove IRQF_ONESHOT. > > > > Reported-by: Benjamin Rouxel <benjamin.rouxel@xxxxxx> > > Tested-by: Benjamin Rouxel <benjamin.rouxel@xxxxxx> > > Cc: Kukjin Kim <kgene@xxxxxxxxxx> > > Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > Cc: linux-samsung-soc@xxxxxxxxxxxxxxx > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > > Krzysztof, are you okay with this change? I do not have a clue what the original author back in 2013 had in mind, but change itself looks reasonable. I also gave it a try and it seems it works fine: Tested-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> Best regards, Krzysztof
