Am 24.07.19 um 15:59 schrieb Andrzej Pietrasiewicz:
> Use the ddc pointer provided by the generic connector.
>
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/ast/ast_mode.c | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
> index c792362024a5..1c899a6e87b7 100644
> --- a/drivers/gpu/drm/ast/ast_mode.c
> +++ b/drivers/gpu/drm/ast/ast_mode.c
> @@ -867,7 +867,14 @@ static int ast_connector_init(struct drm_device *dev)
> return -ENOMEM;
>
> connector = &ast_connector->base;
> - drm_connector_init(dev, connector, &ast_connector_funcs, DRM_MODE_CONNECTOR_VGA);
> + ast_connector->i2c = ast_i2c_create(dev);
> + if (!ast_connector->i2c)
> + DRM_ERROR("failed to add ddc bus for connector\n");
> +
> + drm_connector_init_with_ddc(dev, connector,
> + &ast_connector_funcs,
> + DRM_MODE_CONNECTOR_VGA,
> + &ast_connector->i2c->adapter);
>
> drm_connector_helper_add(connector, &ast_connector_helper_funcs);
>
> @@ -881,10 +888,6 @@ static int ast_connector_init(struct drm_device *dev)
> encoder = list_first_entry(&dev->mode_config.encoder_list, struct drm_encoder, head);
> drm_connector_attach_encoder(connector, encoder);
>
> - ast_connector->i2c = ast_i2c_create(dev);
> - if (!ast_connector->i2c)
> - DRM_ERROR("failed to add ddc bus for connector\n");
> -
> return 0;
> }
>
>
Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Attachment:
signature.asc
Description: OpenPGP digital signature
