On 10.07.2019 12:14, Krzysztof Kozlowski wrote: > On Wed, 10 Jul 2019 at 12:03, Kamil Konieczny > <k.konieczny@xxxxxxxxxxxxxxxxxxx> wrote: >> >> On 10.07.2019 11:00, Krzysztof Kozlowski wrote: >>> On Mon, 8 Jul 2019 at 16:12, <k.konieczny@xxxxxxxxxxxxxxxxxxx> wrote: >>>> >>>> From: Kamil Konieczny <k.konieczny@xxxxxxxxxxxxxxxxxxx> >>>> >>>> Hi, >>>> >>>> The main purpose of this patch series is to add coupled regulators for >>>> Exynos5422/5800 to keep constrain on voltage difference between vdd_arm >>>> and vdd_int to be at most 300mV. In exynos-bus instead of using >>>> regulator_set_voltage_tol() with default voltage tolerance it should be >>>> used regulator_set_voltage_triplet() with volatege range, and this is >>>> already present in opp/core.c code, so it can be reused. While at this, >>>> move setting regulators into opp/core. >>>> >>>> This patchset was tested on Odroid XU3. >>>> >>>> The last patch depends on two previous. >>> >>> So you break the ABI... I assume that patchset maintains >>> bisectability. However there is no explanation why ABI break is needed >>> so this does not look good... >> >> Patchset is bisectable, first one is simple and do not depends on others, >> second depends on first, last depends on first and second. >> >> What do you mean by breaking ABI ? > > I mean, that Linux kernel stops working with existing DTBs... or am I > mistaken and there is no problem? Maybe I confused the order... It is not ABI break, it should work with existing DTBs -- Best regards, Kamil Konieczny Samsung R&D Institute Poland
