On Mon, Apr 15, 2019 at 09:47:19AM +0900, Inki Dae wrote:
> This patch makes error messages to be printed out using DRM_ERROR
> instead of DRM_INFO.
>
> Signed-off-by: Inki Dae <inki.dae@xxxxxxxxxxx>
> ---
> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> index 786a8ee..78427ec 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -400,7 +400,7 @@ static int fimd_atomic_check(struct exynos_drm_crtc *crtc,
> u32 clkdiv;
>
> if (mode->clock == 0) {
> - DRM_INFO("Mode has zero clock value.\n");
> + DRM_ERROR("Mode has zero clock value.\n");
> return -EINVAL;
> }
This seems like it should likely have been caught by
drm_mode_convert_to_umode()->...->drm_mode_validate_basic().
>
> @@ -416,7 +416,7 @@ static int fimd_atomic_check(struct exynos_drm_crtc *crtc,
>
> lcd_rate = clk_get_rate(ctx->lcd_clk);
> if (2 * lcd_rate < ideal_clk) {
> - DRM_INFO("sclk_fimd clock too low(%lu) for requested pixel clock(%lu)\n",
> + DRM_ERROR("sclk_fimd clock too low(%lu) for requested pixel clock(%lu)\n",
> lcd_rate, ideal_clk);
These look like they could user triggerable, in which case they should
be debug messages instead.
> return -EINVAL;
> }
> @@ -424,7 +424,7 @@ static int fimd_atomic_check(struct exynos_drm_crtc *crtc,
> /* Find the clock divider value that gets us closest to ideal_clk */
> clkdiv = DIV_ROUND_CLOSEST(lcd_rate, ideal_clk);
> if (clkdiv >= 0x200) {
> - DRM_INFO("requested pixel clock(%lu) too low\n", ideal_clk);
> + DRM_ERROR("requested pixel clock(%lu) too low\n", ideal_clk);
> return -EINVAL;
> }
>
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
