On Wed, Mar 20, 2019 at 11:32 PM Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> wrote: > > Support for Exynos5420/5422/5800 SoCs requires MCPM to properly boot all > CPU cores on all currectly supported platforms: Peach Pit (Exynos5420), > Odroid XU3/XU3lite/XU4/HC1 (Exynos5422) and Peach Pi (Exynos5800). > Without it some CPU cores fail to come online. Remove then the ability to > disable MCPM and make it mandatory when Exynos542x/5800 support is > enabled. > > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > --- > v3: remove CONFIG_EXYNOS5420_MCPM symbol from defconfigs too > v2: rebased on top of the current exynos-next > --- > arch/arm/configs/exynos_defconfig | 1 - > arch/arm/configs/multi_v7_defconfig | 1 - > arch/arm/mach-exynos/Kconfig | 12 +++--------- > arch/arm/mach-exynos/Makefile | 2 +- > arch/arm/mach-exynos/suspend.c | 12 ++++-------- > 5 files changed, 8 insertions(+), 20 deletions(-) > > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig > index d635edfb6ff2..c95c54284da2 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -9,7 +9,6 @@ CONFIG_MODULE_UNLOAD=y > CONFIG_PARTITION_ADVANCED=y > CONFIG_ARCH_EXYNOS=y > CONFIG_ARCH_EXYNOS3=y > -CONFIG_EXYNOS5420_MCPM=y > CONFIG_SMP=y > CONFIG_BIG_LITTLE=y > CONFIG_NR_CPUS=8 > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > index c75051b9392c..e4b5fd46fdef 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig > @@ -33,7 +33,6 @@ CONFIG_MACH_BERLIN_BG2CD=y > CONFIG_MACH_BERLIN_BG2Q=y > CONFIG_ARCH_DIGICOLOR=y > CONFIG_ARCH_EXYNOS=y > -CONFIG_EXYNOS5420_MCPM=y > CONFIG_ARCH_HIGHBANK=y > CONFIG_ARCH_HISI=y > CONFIG_ARCH_HI3xxx=y > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index b40963cf91c7..62b734a8092b 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -106,21 +106,15 @@ config SOC_EXYNOS5420 > bool "SAMSUNG EXYNOS5420" > default y > depends on ARCH_EXYNOS5 > + select MCPM > + select ARM_CCI400_PORT_CTRL > + select ARM_CPU_SUSPEND This breaks !SMP builds now: http://arm-soc.lixom.net/buildlogs/next/next-20190408/buildall.arm.multi_v7_nosmp_defconfig.log.failed Please use "select MCPM if SMP" instead. -Olof
