On 2/12/19 17:40, Mark Brown wrote: > On Thu, Feb 07, 2019 at 06:00:08PM +0100, Sylwester Nawrocki wrote: > >> I am not entirely sure we should be removing the >> SND_DMAENGINE_PCM_FLAG_CUSTOM_CHANNEL_NAME flag like this, it might all >> be a bit more explicit with the flag. > > I'm fairly happy with what you're doing here and the Samsung driver is > the only user so the view of people working on that is pretty important > here. I've gone ahead and applied the first few patches so they don't > need rereviewing, the rest looked fine modulo the comments from > Krzysztof. Thank you, I've just resent the whole series with Krzysztof's comments addressed and with few more clean up patches added. I've found one minor problem with the Odroid machine driver patch - limiting sampling rate to same value on both PCMs doesn't work properly. I've got a patch fixing that almost ready and will post it tomorrow as a folow up or v3 of "ASoC: samsung: odroid: Add support for secondary CPU DAI".
