On 2/11/19 14:37, Krzysztof Kozlowski wrote: >> @@ -784,6 +787,9 @@ static int i2s_hw_params(struct snd_pcm_substream *substream, >> i2s->frmclk = params_rate(params); >> >> rclksrc = i2s->clk_table[CLK_I2S_RCLK_SRC]; >> + if (!rclksrc || IS_ERR(rclksrc)) > IS_ERR_OR_NULL Thanks for your review! That line will be removed by subsequent patch (7/22) so I'd say such a change wouldn't make a difference anyway. Besides not using IS_ERR_OR_NULL() was intentional. -- Thanks, Sylwester
