Am 23.01.19 um 19:23 schrieb Markus Reichl:
>
>
> Am 23.01.19 um 16:59 schrieb Ulf Hansson:
>> + Marek
>>
>> On Wed, 23 Jan 2019 at 16:37, Markus Reichl <m.reichl@xxxxxxxxxxxxx> wrote:
>>> Am 23.01.19 um 16:08 schrieb Ulf Hansson:
>>>> On Wed, 23 Jan 2019 at 14:30, Markus Reichl <m.reichl@xxxxxxxxxxxxx> wrote:
>>>>> Hi,
>>>>>
>>>>> with all recent kernel versions Reboot hangs on both my Odroid-X2 boards.
>>>>> Boot and root partition reside on eMMC.
>>>>> Last lines on ttySAC1:
>>>>> [ 39.423093] systemd-shutdown[1]: Rebooting.
>>>>> [ ▒
>>>>>
>>>> Thanks for reporting!
>>>>
>>>>> Bisecting points to:
>>>>>
>>>>> d97a1e5d7cd2b5b0edc02a40fe6897b710c9e10f is the first bad commit
>>>>> commit d97a1e5d7cd2b5b0edc02a40fe6897b710c9e10f
>>>>> Author: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
>>>>> Date: Thu Apr 14 14:02:16 2016 +0100
>>>>>
>>>>> mmc: pwrseq: convert to proper platform device
>>>> Hmm, looking at history from git log gives me a hint about that it's
>>>> the dts that may have the wrong pinctrl for the pwrseq node used for
>>>> eMMC.
>>>>
>>>> commit 225da7e65a03 ("ARM: dts: add eMMC reset line for
>>>> exynos4412-odroid-common") was introduced in v4.1, which adds the
>>>> pwrseq node containing a pinctrl. However, at that point pinctrl was
>>>> not a supported DT binding, thus not used by the mmc core.
>>>>
>>>> It's not until the commit you point to above, for when we start
>>>> parsing for pinctrl, via driver core.
>>>>
>>>> So as a test, could you try the patch below, to see if that helps.
>>> Thanks Uffe,
>>>
>>> this fixes reboot.
>>> Tested with kernel v4.20.2.
>>> Tested-by: Markus Reichl <m.reichl@xxxxxxxxxxxxx>
>> Thanks Markus!
>>
>> However, it seems like we need some Exynos guys to confirm that this
>> is an acceptable solution. Or if there is something else we need to
>> do. I have looped in Marek, to what his opinion is.
> I did further tests:
> With an additional SD-Card, even only partly pushed in and therefore
> SD-detect pin operated reboot still hangs.
> Without SD-Card reboot works fine as tested above.
I'm using exynos_defconfig for testing but devfreq must be disabled in kernel config otherwise reboot still doesn't work most of the time.
Now got it rebooting even with an SD-Card plugged in.
>>> Gruß,
>>> --
>>> Markus Reichl
>>>
>>>> From: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
>>>> Date: Wed, 23 Jan 2019 16:00:13 +0100
>>>> Subject: [PATCH] ARM: dts: exynos4412-odroid: Drop pinctrl from eMMC pwrseq
>>>>
>>>> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
>>>> ---
>>>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 --
>>>> 1 file changed, 2 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>> b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>> index 3a9eb1e91c45..beef68ef688d 100644
>>>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>> @@ -49,8 +49,6 @@
>>>> };
>>>>
>>>> emmc_pwrseq: pwrseq {
>>>> - pinctrl-0 = <&sd1_cd>;
>>>> - pinctrl-names = "default";
>>>> compatible = "mmc-pwrseq-emmc";
>>>> reset-gpios = <&gpk1 2 GPIO_ACTIVE_LOW>;
>>>> };
>>>>
>> Kind regards
>> Uffe
>>
>
Gruß,
--
Markus Reichl
Attachment:
signature.asc
Description: OpenPGP digital signature
