On Sat, Jan 19, 2019 at 09:40:10PM +0900, Chanwoo Choi wrote: > Hi Kamil, > > This version only adds following two clocks without that other clocks > be included in imem block. > - CLK_ACLK_SLIMSSS > - CLK_PCLK_SLIMSSS > > Usually, the users only refer to > 'include/dt-bindings/clock/exynos5433.h' in order to get the supported > clocks. It means that if there are different between the clock list in > 'include/dt-bindings/clock/exynos5433.h' and the supported clock list > of drivers/clock/', it make the confusion for users. So, > 'include/dt-bindings/clock/exynos5433.h' have to define the only > supported clock ids. > > Please remove other clock ids except for CLK_ACLK_SLIMSSS/CLK_PCLK_SLIMSSS. And add clocks 1-by-1 instead? The binding headers are a pain to merge because they are a dts and driver dependency. Having a complete header is preferred unless there is doubt in the correctness of it. The driver can warn users about unsupported IDs. Rob
