On 13.12.2018 22:10, Krzysztof Kozlowski wrote: > On Tue, Dec 04, 2018 at 05:52:47PM +0100, Kamil Konieczny wrote: >> Add description for imem clock in the Samsung Exynos5433. The users can use >> compatibility "samsung,exynos5433-cmu-imem". > > Thanks, applied but the commit message above is not matching contents at all. > You did not add the description. Mentioning some users and compatibility > also seems unrelated. Instead: > 1. You added DT node for IMEM clock controller on Exynos5433. > 2. Because it is necessary for SSS to work (beside obvious reasons: for > DTS completeness and allowing to gate them when not used). > Also, please use SoC name in commit title (for example at the end) to > differentiate from Exynos7 or any other future SoCs. Thank you for your work and insightfull comments, I hope to improve my commit messages. -- Best regards, Kamil Konieczny Samsung R&D Institute Poland
