Hi MyungJoo, On 11/26/18 9:14 AM, MyungJoo Ham wrote: >> The patch prepares devfreq device for handling suspend/resume functionality. >> The new fields will store needed information during this process. >> Devfreq framework handles opp-suspend DT entry and there is no need of >> modyfications in the drivers code. >> >> The patch draws on Tobias Jakobi's work posted ~2 years ago, who tried to >> solve issue with devfreq device's frequency during suspend/resume. >> During the discussion on LKML some corner cases and comments appeared >> related to the design. This patch address them keeping in mind suggestions >>from Chanwoo Choi. >> >> Suggested-by: Tobias Jakobi <tjakobi@xxxxxxxxxxxxxxxxxxxxx> >> Suggested-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> >> Signed-off-by: Lukasz Luba <l.luba@xxxxxxxxxxxxxxxxxxx> > > When you add new elements in a common struct (i.e., struct devfreq), > please describe kindly in the doxygen entries so that developers > may understand before reading all places where the new elements are > used. > > You have added three new elements and there is no explanations on them. You are right, thank you for the review. I will fix it in the next patch set version. Regards, Lukasz > > > Cheers, > MyungJoo > > >
