On Tue, Nov 20, 2018 at 02:54:24PM +0100, Marek Szyprowski wrote: > Add RTC driver for MAX8998 chip used on Samsung UniversalC210 board. > > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > --- > arch/arm/configs/exynos_defconfig | 1 + > 1 file changed, 1 insertion(+) In general it looks OK but maybe you want to enable charger/power supply driver as well? Somehow I missed the exynos_defconfig in d649ca009766 ("ARM: multi_v7_defconfig: Enable drivers for Exynos4210 Universal C210 board")... Best regards, Krzysztof > > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig > index 27ea6dfcf2f2..d22ff017385f 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -273,6 +273,7 @@ CONFIG_LEDS_MAX77693=y > CONFIG_LEDS_MAX8997=y > CONFIG_LEDS_TRIGGER_HEARTBEAT=y > CONFIG_RTC_CLASS=y > +CONFIG_RTC_DRV_MAX8998=y > CONFIG_RTC_DRV_MAX8997=y > CONFIG_RTC_DRV_MAX77686=y > CONFIG_RTC_DRV_S5M=y > -- > 2.17.1 >