Quoting Marek Szyprowski (2018-10-08 07:51:30) > Hi Stephen, > > On 2018-10-08 04:47, Stephen Boyd wrote: > > Quoting Marek Szyprowski (2018-10-02 04:52:10) > >> @@ -432,7 +432,7 @@ int __init exynos_register_cpu_clock(struct samsung_clk_provider *ctx, > >> else > >> cpuclk->clk_nb.notifier_call = exynos_cpuclk_notifier_cb; > >> > >> - cpuclk->alt_parent = __clk_lookup(alt_parent); > >> + cpuclk->alt_parent = __clk_get_hw(__clk_lookup(alt_parent)); > > It would be nice to get rid of __clk_lookup() from here too. Please try > > to do that if at all possible. > > So far it won't be possible to get rid of __clk_lookup() completely from > samsung/clk-cpu.c, because there is a need to register clk notifier for > CPU clock, but there is no clk_hw_notifier_register() api. I'm not sure if > this is the right way to add it. > Probably there needs to be some way to indicate that the alt_parent is going here and then grab the clk_hw pointer to it. Instead of looking up a clk by random string name. I don't really care about the clk_notifier_register() API, that's fine. Eventually I'd like to see that API not be used by clk provider drivers.
