Re: [PATCH] mmc: slot-gpio: Fix debounce time to use miliseconds again

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28 September 2018 at 14:20, Marek Szyprowski
<m.szyprowski@xxxxxxxxxxx> wrote:
> The debounce value passed to mmc_gpiod_request_cd() function is in
> microseconds, but msecs_to_jiffies() requires the value to be in
> miliseconds to properly calculate the delay, so adjust the value stored
> in cd_debounce_delay_ms context entry.
>
> Fixes: 1d71926bbd59 ("mmc: core: Fix debounce time to use microseconds")
> Fixes: bfd694d5e21c ("mmc: core: Add tunable delay before detecting card
> after card is inserted")
> Cc: stable@xxxxxxxxxxxxxxx # v4.18+
> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>

Applied for fixes!

Kind regards
Uffe

> ---
> This patch fixes eMMC card detection on Exynos5410-based Odroid XU board,
> broken since Linux next-20180928.
> ---
>  drivers/mmc/core/slot-gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/slot-gpio.c b/drivers/mmc/core/slot-gpio.c
> index 2a833686784b..86803a3a04dc 100644
> --- a/drivers/mmc/core/slot-gpio.c
> +++ b/drivers/mmc/core/slot-gpio.c
> @@ -271,7 +271,7 @@ int mmc_gpiod_request_cd(struct mmc_host *host, const char *con_id,
>         if (debounce) {
>                 ret = gpiod_set_debounce(desc, debounce);
>                 if (ret < 0)
> -                       ctx->cd_debounce_delay_ms = debounce;
> +                       ctx->cd_debounce_delay_ms = debounce / 1000;
>         }
>
>         if (gpio_invert)
> --
> 2.17.1
>



[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux