On Thu, 27 Sep 2018 at 05:45, Anand Moon <linux.amoon@xxxxxxxxx> wrote: > > Hi Krzysztof, > On Thu, 27 Sep 2018 at 00:36, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > > > On Sat, Sep 22, 2018 at 07:52:36AM +0000, Anand Moon wrote: > > > Add the card-detect and write-protect GPIO pins for OdroidXU3/XU4 > > > SD card by adding pinctrl setting for wp-gpio pin and set it to > > > active low. > > > > > > This also removes debug messages: > > > dwmmc_exynos 12220000.mmc: No GPIO consumer cd found > > > dwmmc_exynos 12220000.mmc: No GPIO consumer wp found > > > > > > Suggested-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx> > > > --- > > > Fix the commit message and squash it with cd-gpios and wp-gpio > > > patches into single patch as suggested by Krzysztof. > > > > As Marek pointed to my Odroid XU patch, there is no point of adding > > cd-gpios and wp-gpios properties. > > > > Adding pin configuration for wp pin is also not needed. Reset values are > > working properly. However there might be meaning of adding it just in > > case - if bootloader decided to touch it... > > > > Best regards, > > Krzysztof > > > > Do I need to send the all the patches again or just resend this as per > your patch for Odroid XU. > with dropping the cd-gpios and wp-gpios changes. I am fine with both (resend all or only this). Best regards, Krzysztof
