Thanks Christoph for patches! On Thu, 13 Sep 2018 at 09:59, Christoph Manszewski <c.manszewski@xxxxxxxxxxx> wrote: > > Modifications in s5p-sss.c: > > - remove unnecessary 'goto' statements, > No need of empty lines here. > - change uint_8 and uint_32 to u8 and u32 types, Please add rationale for this, e.g.: "for consistency in the driver and making code shorter". Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> Best regards, Krzysztof