On Thu, 30 Aug 2018 at 14:50, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> wrote:
>
> Hi Krzysztof,
>
> On 2018-08-30 08:42, Krzysztof Kozlowski wrote:
> > On Wed, 29 Aug 2018 at 17:51, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> wrote:
> >> Replace common suspend/resume handling code by generic helper.
> >> No functional change.
> >>
> >> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> >> ---
> >> drivers/clk/samsung/clk-s3c2412.c | 43 ++-----------------------------
> >> 1 file changed, 2 insertions(+), 41 deletions(-)
> >>
> >> diff --git a/drivers/clk/samsung/clk-s3c2412.c b/drivers/clk/samsung/clk-s3c2412.c
> >> index 6bc94d3aff78..dd1159050a5a 100644
> >> --- a/drivers/clk/samsung/clk-s3c2412.c
> >> +++ b/drivers/clk/samsung/clk-s3c2412.c
> >> @@ -11,7 +11,6 @@
> >> #include <linux/clk-provider.h>
> >> #include <linux/of.h>
> >> #include <linux/of_address.h>
> >> -#include <linux/syscore_ops.h>
> >> #include <linux/reboot.h>
> >>
> >> #include <dt-bindings/clock/s3c2412.h>
> >> @@ -29,9 +28,6 @@
> >>
> >> static void __iomem *reg_base;
> >>
> >> -#ifdef CONFIG_PM_SLEEP
> >> -static struct samsung_clk_reg_dump *s3c2412_save;
> >> -
> >> /*
> >> * list of controller registers to be saved and restored during a
> >> * suspend/resume cycle.
> >> @@ -45,42 +41,6 @@ static unsigned long s3c2412_clk_regs[] __initdata = {
> >> CLKSRC,
> > Did you try building without PM_SLEEP? Now this will be included
> > always so you might have to mark it __maybe_unused.
>
> Nope, there is no such need, because *_regs arrays are passed to a
> samsung_clk_sleep_init() noop function not a noop marco.
Right.
Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Best regards,
Krzysztof
