Hi Krzysztof, On 2018-08-30 08:39, Krzysztof Kozlowski wrote: > On Wed, 29 Aug 2018 at 17:51, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> wrote: >> Replace common suspend/resume handling code by generic helper. >> No functional change. > There is functional change in case alloc fails (kzalloc(), > samsung_clk_alloc_reg_dump()). Previously it would be warned and > ignored. Now it will panic. You could mention this but anyway the > change looks nice! Thanks! No problem to replace panic() in samsung_clk_sleep_init() with a pair of warn and return error as this is probably now a preferred behavior. This is still truly hypothetical discussion because system, which fails to allocate memory at boot is useless anyway. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
