On Wed, 29 Aug 2018 at 18:00, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> wrote: > > Clocks should be suspended as late as possible and resumed as early as > possible to let other drivers do their own suspend/resume tasks. NOIRQ > callbacks better suit this requirement. I think that's not a good reason to use the noirq versions. These are to solve the races with interrupt handlers, not to manually order callbacks. Best regards, Krzysztof > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > --- > drivers/clk/samsung/clk-exynos5433.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c > index 162de44df099..426980514e67 100644 > --- a/drivers/clk/samsung/clk-exynos5433.c > +++ b/drivers/clk/samsung/clk-exynos5433.c > @@ -5630,7 +5630,7 @@ static const struct of_device_id exynos5433_cmu_of_match[] = { > static const struct dev_pm_ops exynos5433_cmu_pm_ops = { > SET_RUNTIME_PM_OPS(exynos5433_cmu_suspend, exynos5433_cmu_resume, > NULL) > - SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, > + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, > pm_runtime_force_resume) > }; > > -- > 2.17.1 >