On 13/08/18 16:11, Krzysztof Kozlowski wrote:
> irq_data->hwirq is unsigned long. This fixes GCC warning:
>
> drivers/irqchip/irq-s3c24xx.c: In function 's3c_irqext0_type':
> drivers/irqchip/irq-s3c24xx.c:253:19: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
> if ((data->hwirq >= 0) && (data->hwirq <= 3)) {
> ^~
>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> ---
> drivers/irqchip/irq-s3c24xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-s3c24xx.c b/drivers/irqchip/irq-s3c24xx.c
> index f6fd57ebe6e6..c19766fe8a1a 100644
> --- a/drivers/irqchip/irq-s3c24xx.c
> +++ b/drivers/irqchip/irq-s3c24xx.c
> @@ -250,7 +250,7 @@ static int s3c_irqext0_type(struct irq_data *data, unsigned int type)
> void __iomem *gpcon_reg;
> unsigned long gpcon_offset, extint_offset;
>
> - if ((data->hwirq >= 0) && (data->hwirq <= 3)) {
> + if (data->hwirq <= 3) {
> gpcon_reg = S3C2410_GPFCON;
> extint_reg = S3C24XX_EXTINT0;
> gpcon_offset = (data->hwirq) * 2;
>
Queued, thanks.
M.
--
Jazz is not dead. It just smells funny...
