On Sun, Jun 10, 2018 at 4:15 PM, Paweł Chmiel <pawel.mikolaj.chmiel@xxxxxxxxx> wrote: > This commit adds missing interrupt-controller property to gph2 block, Just "Add missing". See: https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151 > to silence following warnings during build > /soc/pinctrl@e0200000/gph2: Missing interrupt-controller or interrupt-map property > > Observed on not yet mainlined, an S5PV210 based > Samsung Galaxy S (i9000) phone. The warning is not reproduceable (as you mentioned board is not present in mainline) thus please skip it. Instead, either describe existing reason for this change (e.g. because bindings require it for node of every bank of pins supporting GPIO interrupts) or include this in series mainlining new board (where the reason will be - it will be used by new board etc). Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html