On 2018-05-10 10:44, Andrzej Hajda wrote:
> On 09.05.2018 21:45, Peter Rosin wrote:
>> The variables are always assigned before use anyway.
>>
>> Signed-off-by: Peter Rosin <peda@xxxxxxxxxx>
>> ---
>> drivers/i2c/busses/i2c-exynos5.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c
>> index a2cbc779c33a..185fba37e830 100644
>> --- a/drivers/i2c/busses/i2c-exynos5.c
>> +++ b/drivers/i2c/busses/i2c-exynos5.c
>> @@ -707,7 +707,7 @@ static int exynos5_i2c_xfer(struct i2c_adapter *adap,
>> struct i2c_msg *msgs, int num)
>> {
>> struct exynos5_i2c *i2c = adap->algo_data;
>> - int i = 0, ret = 0, stop = 0;
>> + int i, ret, stop;
>
> I hope gcc is smart enough to not complain in case of ret.
I think any compiler is smart enough to see that; you must have missed
this line:
ret = clk_enable(i2c->clk);
which is the first to touch ret in the function.
> I think you can merge both patches into one.
I could, but I wanted to make the patches totally obvious and easy to
review. The patches do independent things, so I prefer not to squash.
Cheers,
Peter
>
> Regards
> Andrzej
>
>>
>> if (i2c->suspended) {
>> dev_err(i2c->dev, "HS-I2C is not initialized.\n");
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
