On Wed, May 31, 2017 at 9:58 PM, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxx> wrote: > On Wed, May 24, 2017 at 05:58:34PM +0200, Arnd Bergmann wrote: > Yes, selecting ARM_AMBA from drivers is definitely not right; this > symbol should be selected only by platforms that want AMBA primecell > bus support, not by drivers, precisely because of these dependency > issues. > > There's another case where ARM_AMBA is selected that probably needs > fixing - the coresight hwtracing code. [Adding Mathieu to cc] Mathieu, do you remember how we ended up with this? menuconfig CORESIGHT bool "CoreSight Tracing Support" select ARM_AMBA As Russell says, probably shouldn't select that symbol, most likely we want either the individual drivers that register an amba_driver to have a 'depends on ARM_AMBA' or alternatively replace the 'select' with 'depends on' for the entire subsystem. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html