On Friday 07 April 2017 01:54 PM, Krzysztof Kozlowski wrote:
> On Thu, Mar 30, 2017 at 3:16 PM, Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> wrote:
>> soc_is_exynosMMMM is staged for removal after adopting to exynos-chipid
>> driver, so let's remove/minimize usage of any such helper function usage
>> from pm.c.
>>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx>
>> ---
>> arch/arm/mach-exynos/pm.c | 22 ++++++++++++----------
>> include/linux/soc/samsung/exynos-regs-pmu.h | 3 +++
>> 2 files changed, 15 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm/mach-exynos/pm.c
>> index 1a7e5b5..4a73b02 100644
>> --- a/arch/arm/mach-exynos/pm.c
>> +++ b/arch/arm/mach-exynos/pm.c
>> @@ -123,11 +123,13 @@ int exynos_pm_central_resume(void)
>> }
>>
>> /* Ext-GIC nIRQ/nFIQ is the only wakeup source in AFTR */
>> -static void exynos_set_wakeupmask(long mask)
>> +static void exynos_set_wakeupmask(void)
>> {
>> - pmu_raw_writel(mask, S5P_WAKEUP_MASK);
>> - if (soc_is_exynos3250())
>> + if (of_machine_is_compatible("samsung,exynos3250")) {
>> + pmu_raw_writel(EXYNOS3_WAKEUP_MASK_VAL, S5P_WAKEUP_MASK);
>> pmu_raw_writel(0x0, S5P_WAKEUP_MASK2);
>> + } else
>> + pmu_raw_writel(EXYNOS_WAKEUP_MASK_VAL, S5P_WAKEUP_MASK);
>
> You need {} around this too. Checkpatch should complain about it as
> well so be sure to run it.
>
I ran checkpatch before posting, but it didn't complain about this. Here
is the result when I ran it again today on the same patch.
./scripts/checkpatch.pl
exynos-chipid-v9/0002-ARM-EXYNOS-remove-usage-of-soc_is_exynosMMMM-from-pm.patch
total: 0 errors, 0 warnings, 81 lines checked
exynos-chipid-v9/0002-ARM-EXYNOS-remove-usage-of-soc_is_exynosMMMM-from-pm.patch
has no obvious style problems and is ready for submission.
Thanks,
Pankaj Dubey
> Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>
> Best regards,
> Krzysztof
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
