On Fri, Jan 20, 2017 at 07:51:43AM +0100, Marek Szyprowski wrote: > Hi Krzysztof, > > On 2017-01-19 21:35, Krzysztof Kozlowski wrote: > > On Thu, Jan 19, 2017 at 02:58:30PM +0100, Marek Szyprowski wrote: > > > Common definition for I2S0 bus should not define any pull control for > > > the individual I2S pins. Correct this by changing samsung,pin-pud property > > > to EXYNOS_PIN_PULL_NONE like it is used for other Exynos SoCs. > > > > > > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > > > --- > > > arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > Makes sense. Two questions here: > > 1. The same for pcm0_bus? > > Right, and for I2S1, PMC1 and SPDIF. I will send a new patch. > > > 2. This will affect the specific boards: TM2s. Do they need pull down or > > in fact you wanted to fix them as well? Usage of words "common > > definition" suggests the board might be different and in fact you are > > changing the board now. > > I've check, audio on TM2 works fine without this pull down. I wrote 'common' > because all other Exynos SoCs define audio pins without pull down. If pull > down would be really needed for some reasons on TM2, I would override pull > control in tm2.dts OK, thanks for explanation. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |