On Thu, Jan 19, 2017 at 02:58:30PM +0100, Marek Szyprowski wrote: > Common definition for I2S0 bus should not define any pull control for > the individual I2S pins. Correct this by changing samsung,pin-pud property > to EXYNOS_PIN_PULL_NONE like it is used for other Exynos SoCs. > > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > --- > arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Makes sense. Two questions here: 1. The same for pcm0_bus? 2. This will affect the specific boards: TM2s. Do they need pull down or in fact you wanted to fix them as well? Usage of words "common definition" suggests the board might be different and in fact you are changing the board now. Best regards, Krzysztof > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi > index d49879bd34bb..2171ff965212 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi > @@ -135,7 +135,7 @@ > samsung,pins = "gpz0-0", "gpz0-1", "gpz0-2", "gpz0-3", > "gpz0-4", "gpz0-5", "gpz0-6"; > samsung,pin-function = <EXYNOS_PIN_FUNC_2>; > - samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>; > + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; > samsung,pin-drv = <EXYNOS5433_PIN_DRV_FAST_SR1>; > }; > > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |