Re: [PATCH] ARM: dts: exynos: Enable SPI on 4412 based odroid-X and -X2 boards.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Markus,


On 2016-11-24 15:13, Markus Reichl wrote:
Odroid-X and -X2 have SPI_1 routed to an external connector.
Enable SPI_1 on X and -X2.

Signed-off-by: Markus Reichl <m.reichl@xxxxxxxxxxxxx>

Thanks for this patch. Maybe it would make sense also to enable I2C controller,
which is also available on the external connector?

Then I would also like to add some kind of comment in the DTS on which pins given bus/feature is available. This should help a lot people trying to connect external
sensors to the Odroid boards.

For this patch:

Acked-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>

---
Tested on X, U3.
---
  arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 8 ++++++++
  arch/arm/boot/dts/exynos4412-odroidu3.dts       | 7 -------
  2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index 7dc1009..c919405 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -559,6 +559,14 @@
  	status = "okay";
  };
+&spi_1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&spi1_bus>;
+	num-cs = <1>;
+	cs-gpios = <&gpb 5 GPIO_ACTIVE_HIGH>;
+	status = "okay";
+};
+
  &tmu {
  	vtmu-supply = <&ldo10_reg>;
  	status = "okay";
diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
index fc14da5..4bd215f 100644
--- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
@@ -124,10 +124,3 @@
  		"Speakers", "SPKL",
  		"Speakers", "SPKR";
  };
-
-&spi_1 {
-	pinctrl-names = "default";
-	pinctrl-0 = <&spi1_bus>;
-	cs-gpios = <&gpb 5 GPIO_ACTIVE_HIGH>;
-	status = "okay";
-};

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux