Ah sorry, I didn't look carefully and thought you moved the node from the U3 to the X DTS. Mea culpa! :( - Tobias Markus Reichl wrote: > Hi Tobias, > > Am 24.11.2016 um 15:29 schrieb Tobias Jakobi: >> Hey Markus, >> >> you should probably mention why the node was removed from the U3 dts. I >> guess this is due to the SPI not being routed anywhere there? > > I put the node into exynos4412-odroid-common, so it will be there > on X, X2 and U3. > We need it on U3, too, because on U3+ SPI is routed to an external connector. > (Presently we do not separate between U3 and U3+. They are different only with > SPI and USB-OTG). > > Thanks for looking at, > -- > Markus > >> >> - Tobias >> >> Markus Reichl wrote: >>> Odroid-X and -X2 have SPI_1 routed to an external connector. >>> Enable SPI_1 on X and -X2. >>> >>> Signed-off-by: Markus Reichl <m.reichl@xxxxxxxxxxxxx> >>> --- >>> Tested on X, U3. >>> --- >>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 8 ++++++++ >>> arch/arm/boot/dts/exynos4412-odroidu3.dts | 7 ------- >>> 2 files changed, 8 insertions(+), 7 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi >>> index 7dc1009..c919405 100644 >>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi >>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi >>> @@ -559,6 +559,14 @@ >>> status = "okay"; >>> }; >>> >>> +&spi_1 { >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&spi1_bus>; >>> + num-cs = <1>; >>> + cs-gpios = <&gpb 5 GPIO_ACTIVE_HIGH>; >>> + status = "okay"; >>> +}; >>> + >>> &tmu { >>> vtmu-supply = <&ldo10_reg>; >>> status = "okay"; >>> diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts >>> index fc14da5..4bd215f 100644 >>> --- a/arch/arm/boot/dts/exynos4412-odroidu3.dts >>> +++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts >>> @@ -124,10 +124,3 @@ >>> "Speakers", "SPKL", >>> "Speakers", "SPKR"; >>> }; >>> - >>> -&spi_1 { >>> - pinctrl-names = "default"; >>> - pinctrl-0 = <&spi1_bus>; >>> - cs-gpios = <&gpb 5 GPIO_ACTIVE_HIGH>; >>> - status = "okay"; >>> -}; >>> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html