On 10/27/2016 04:23 PM, Mark Brown wrote:
> On Thu, Oct 27, 2016 at 01:21:21PM +0200, Sylwester Nawrocki wrote:
>> On 10/25/2016 05:08 PM, Sylwester Nawrocki wrote:
>>> Since commit 194c7dea00c68c1b1f8ff26304fa937a006f66dd
>>> "ASoC: dmaengine: add custom DMA config to snd_dmaengine_pcm_config"
>>> custom DMA channels can be also specified in chan_names[] field of
>>> struct snd_dmaengine_pcm_config. This patch removes chan_name field
>>> of struct snd_dmaengine_dai_dma_data as it is now unused.
>>>
>>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
>>
>> I'm afraid this patch needs to be reverted :/ I didn't notice earlier
>> the Samsung AC97 controller has 3 substreams per a platform device and
>> this cannot be handled with struct snd_dmaengine_pcm_config, which
>> allows to specify up to 2 DMA channel names.
>
> Can you send a revert patch with an explanation though...
Sure, I'll prepare the patch.
>> The AC97 driver (sound/soc/samsung/ac97.c) seems to have been broken
>> for a long time as it currently doesn't have the channel names
>> specified at all [1]. It seems in order to fix it the best would
>> be to restore the feature the $subject patch removes.
>
> ...if the driver just doesn't work and hasn't worked for a long time
> perhaps it's better to just drop the driver?
I'm not opposed to that, the feature certainly hasn't been used for
a long time with mainline kernels.
Then I think these drivers could be dropped as well:
sound/soc/samsung/ln2440sbc_alc650.c
sound/soc/samsung/smdk2443_wm9710.c
sound/soc/samsung/smdk_wm9713.c
That all could be added again with support for new frameworks if there
are requests to support the feature.
I'm going to post patches removing those drivers.
Still I'd like to revert $subject patch to be able to handle more than
2 substreams per DMA device. I planned to get rid of an additional
platform device creation in sound/soc/samsung/i2s.c, which IIUC
introduces now unnecessary complication, could be avoided and doesn't
match the hardware very well. Not quite sure it that would be
the right direction but I think being able to specify custom DMA channel
names per DAI DMA data could be helpful in doing that. I.e. to have
1 PCM with 3 substreams {"tx", "rx", "tx-sec"} instead of 2 PCMs with
substreams {"tx", "rx"} and {"tx-sec"}.
--
Thanks,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
