On Thu, Oct 27, 2016 at 01:21:21PM +0200, Sylwester Nawrocki wrote: > On 10/25/2016 05:08 PM, Sylwester Nawrocki wrote: > > Since commit 194c7dea00c68c1b1f8ff26304fa937a006f66dd > > "ASoC: dmaengine: add custom DMA config to snd_dmaengine_pcm_config" > > custom DMA channels can be also specified in chan_names[] field of > > struct snd_dmaengine_pcm_config. This patch removes chan_name field > > of struct snd_dmaengine_dai_dma_data as it is now unused. > > > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> > > I'm afraid this patch needs to be reverted :/ I didn't notice earlier > the Samsung AC97 controller has 3 substreams per a platform device and > this cannot be handled with struct snd_dmaengine_pcm_config, which > allows to specify up to 2 DMA channel names. Can you send a revert patch with an explanation though... > The AC97 driver (sound/soc/samsung/ac97.c) seems to have been broken > for a long time as it currently doesn't have the channel names > specified at all [1]. It seems in order to fix it the best would > be to restore the feature the $subject patch removes. ...if the driver just doesn't work and hasn't worked for a long time perhaps it's better to just drop the driver?
Attachment:
signature.asc
Description: PGP signature
