On 18/03/2016 at 13:07:17 +0100, Alexandre Belloni wrote : > On 18/03/2016 at 08:57:57 -0300, Javier Martinez Canillas wrote : > > >>> But yes, we can at least get rid of the else statement. I don't have a > > >>> strong opinion about the debug information, I left it to avoid someone > > >>> to tell me that I was removing a useful log. > > >> > > >> Although dev_dbg doesn't harm... but isn't driver core printing debug > > >> message already? > > >> > > > > > > I don't think it does or at least I didn't find it when looking > > > at the devm_clk_get() call chain. > > > > > >> BR, > > >> Krzysztof > > >> > > > > Just to make sure that I understood correctly, there's no action I > > should take in order for this patch to be picked right? IOW, the > > current version is OK? > > > > I was kind of waiting an answer on the question whether the core already > prints a message when probe dereferral happens because in that case, > there is no need for a debug message and we can indeed simplify the > whole block. Ok, I've found the recent commit 13fcffbbdec4e4863a9a9c7792b821cd6d363a8f I'll take the patch as is. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |