On Mon, 15 Feb 2016, Krzysztof Kozlowski wrote: > On 12.02.2016 13:30, Javier Martinez Canillas wrote: > > The driver's init and exit function don't do anything besides adding and > > deleting the I2C driver so the module_i2c_driver() macro could be used. > > > > Currently is not being used because the driver is initialized at subsys > > initcall level, claiming that this is done to allow consumers devices to > > use the resources provided by this driver. But dependencies should be in > > the DT and consumers drivers should not rely in the registration order. > > > > Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> > > --- > > > > drivers/mfd/max77686.c | 13 +------------ > > 1 file changed, 1 insertion(+), 12 deletions(-) > > > > In the past not all dependencies supported deferred probing so such > ordering was required. > > I don't like the "dependencies should be in DT" reason for the change... > because it is kind of wishful thinking. Yeah, the dependencies should be > in DT, but are they? > > Instead *please check it* and write: > "Dependencies are in DT so manual ordering of init calls is not > necessary any more". > > My fast tests of this patch shown that it works good... but some more > thorough tests should be done. See to all of this, collect the Acks you've received and re-submit please. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |