Hello Krzysztof, On 12/08/2015 05:13 AM, Krzysztof Kozlowski wrote: > On 08.12.2015 03:18, Bartlomiej Zolnierkiewicz wrote: >> From: Ben Gamari <ben@xxxxxxxxxxxxxxxx> >> >> The Exynos 5422 is identical to the 5800 except for the fact that it >> boots from the A7 cores. Consequently, the core numbering is different: >> cores 0-3 are A7s whereas 4-7 are A15s. >> >> We can reuse the device tree of the 5800 for the 5422 but we must take >> care to override the OPP tables and CPU clocks. These are otherwise >> inherited from the exynos5800 devicetree, which has the CPU clusters >> reversed compared to the 5422. This results in the A15 cores only >> reaching 1.4GHz, the maximum rate of the KFC clock. >> >> Cc: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> >> Signed-off-by: Ben Gamari <ben@xxxxxxxxxxxxxxxx> >> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> >> --- >> arch/arm/boot/dts/exynos5422-cpus.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> > > This looks like a very-non-atomic way of handling a change. You added > opp tables to exynos5420 before so at that time they will be applied to > Odroid XU3 family which uses different CPU order. After that you are > fixing the tables to proper CPU order. Direct bisectability probably > won't be an issue because all of DTS would go to separate branch... but > the logic behind confuses. > Agreed. > I think this should be squashed into 3/8. > I think the patch should be split in two changes, the CPUs device nodes having the wrong clock for clusters is a bug and has to be fixed in a patch before adding the OPP tables and the OPP tables changes should be separated and merged with patch 3/8 as you suggest. > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |