On 29.10.2015 15:54, Pavel Fedin wrote: > Hello! > Where is the contents of email and patch? >>> + for_each_child_of_node(np, child) >>> + decode_sromc(srom, child); >> >> You ignore the return value here so bank may be not configured but >> device probe will return 0. > > Yes, so that banks which are described correctly, will still be configured. But the system won't get any information about the failure. Device using these banks should not probe in such case. > >> Maybe clean up and fail the probe? > > I think it's not fatal, so cleanup is not necessary. May be dev_warn() in this case? Now this is just silently ignoring return value (which is not needed then) and not printing any errors. But that actually depends on previous comment - whether the driver will fail the probe. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |