Hello! > > + for_each_child_of_node(np, child) > > + decode_sromc(srom, child); > > You ignore the return value here so bank may be not configured but > device probe will return 0. Yes, so that banks which are described correctly, will still be configured. > Maybe clean up and fail the probe? I think it's not fatal, so cleanup is not necessary. May be dev_warn() in this case? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |