On Sun, 25 Jan 2015 19:31:14 +0530
Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> On 23 January 2015 at 19:27, Lukasz Majewski <l.majewski@xxxxxxxxxxx>
> wrote:
> > Please pay a note about following problem:
> >
> > Previously we got: cpu0: cpu@0 for all Exynos devices.
> >
> > Now, however, cpu numbering has changed (due to GIC rework).
> > For example:
> >
> > Exynos4412:
> > cpus {
> > cpu0: cpu@A00 {
> > ...
> > #cooling-cells = <2>; /* min followed by
> > max */ };
> >
> > cpu@A01 {
> > };
> >
> > cpu@A02 {
> > };
> >
> > cpu@A03 {
> > };
> > }
> >
> > Exynos 4210:
> > cpus {
> > cpu0: cpu@900 {
> > #cooling-cells = <2>; /* min followed by
> > max */ };
> >
> > cpu@901 {
> > };
> > };
> >
> > Exynos 5250:
> > cpus {
> > cpu0: cpu@0 {
> > #cooling-cells = <2>; /* min followed by
> > max */ };
> >
> > cpu@1 {
> > };
> > };
> >
> >
> > As you can see different cpu@XXY nodes we have and simply calling
> > cpu@0 won't work.
>
> I wasn't asked you to get the cpu0 node from dt but this:
>
> cpu_dev = get_cpu_dev(0);
> np = of_node_get(cpu_dev->of_node);
Ingenious simplicity :-)
>
> Wouldn't this work? You only need to guarantee that the cooling-cells
> is added onto the boot CPUs node.
I will test it tomorrow and share results.
Viresh, thanks for tip.
Best regards,
Lukasz Majewski
Attachment:
pgphENOWMiJPK.pgp
Description: OpenPGP digital signature
