Hi Tobias, > Hello! > > Lukasz Majewski wrote: > > We all know that this code is floating around - early version of > > this work was posted in the Q3 2013. > > > > To be fair - this code is both needed and welcome, but new problems > > with it are found (please search for recent comment from Kevin > > Hilman). > > > > From my side, I focus on the code which is in Eduardo Valentin's > > next (3.19-rc3), since I don't know when and if eventually cpufreq > > rework would be merged. > I'm sorry, my wording wasn't the best here. I'm not critizing the work > done here, merely voicing my concern (and also interest!) about how > the new stuff interacts with code that may eventually get merged. > You're aware of it, that's enough for me to know. I'm aware of Thomas work and probably will integrate it when finally it is merged. > > > > The code which touches exynos-cpufreq.c is around 30 LOC, only for > > preserving cpu cooling functionality. > > > > Is it worth to wait for code developed for so long to happily apply > > 30 LOC and delay removal of around 400 LOC in other subsystem > > (thermal)? > No, of course not. That was pretty stupid of me :( > > > > I rise my hand as a volunteer to fix any thermal related issues > > which show up after cpufreq rework code applying to Exynos. > That's certainly good to hear! > > > > This series is NOT providing any NEW functionality. It in fact > > preserves functionality, which allows using CPU frequency as a mean > > to cool the device. > I've got a question concerning this. Is this only needed for > exynos-cpufreq, or does cpufreq-dt also need something like that. In the __cpufreq_add_dev() you have cpufreq_driver->ready() callback which in the cpufreq-dt.c has call to of_cpufreq_cooling_register(). It seems like cpufreq-dt is ready for handling cpu cooling devices. > > The point is that I'm still working with a rather old version of the > cpufreq series, a version which still had the Exynos4x12 code in it > (this was removed later, if I remember correctly because of problems > with how to properly describe boost configuration in DT). Is your board Odroid-U3/Trats2 ? > > > Anyway, to not get completly off-topic here, I noticed some small > issue with v3 of the thermal series. I've enabled > CONFIG_THERMAL_HWMON so that I can use lm_sensors to query > temperature of the board. However while the thermal_zone is created, > there is no hwmon node to be found. I'm not surprised, that some use cases (about which I wasn't even aware) show up. I've already fixed issues reported by Abhilash (with v5 and a following patch) and look closer into the THERMAL_HWMON. I've also done some work regarding FAN controlled by hwmon for Odroid U3. Could you look on following series: http://www.spinics.net/lists/linux-samsung-soc/msg40471.html I can only guess that your board might need similar entries for your DTS file(s). > This was working properly without > the thermal series. Thanks for testing the patch set :-) > > > With best wishes, > Tobias > -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |