Hi Kukjin, On Sun, Nov 9, 2014 at 10:09 AM, Kukjin Kim <kgene@xxxxxxxxxx> wrote: > Abhilash Kesavan wrote: >> >> On Mon, Nov 3, 2014 at 1:51 PM, Abhilash Kesavan >> <kesavan.abhilash@xxxxxxxxx> wrote: >> > Hello Kukjin, >> > >> > On Fri, Oct 31, 2014 at 8:06 AM, Abhilash Kesavan >> > <kesavan.abhilash@xxxxxxxxx> wrote: >> >> Hi Kukjin, >> >> >> >> On Tue, Oct 28, 2014 at 5:56 PM, Abhilash Kesavan >> >> <kesavan.abhilash@xxxxxxxxx> wrote: >> >>> Hi Kukjin >> >>> >> >>> On Tue, Oct 28, 2014 at 4:01 PM, Kukjin Kim <kgene@xxxxxxxxxx> wrote: >> >>>> Abhilash Kesavan wrote: >> >>>>> >> >>>> Hi, >> >>>> >> >>>> Sorry for late response. >> >>>> >> >>>>> Remove symbols SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS which >> >>>>> select the number of UART ports available on the SoC. Replace the usage >> >>>>> of SERIAL_SAMSUNG_UARTS in the serial driver with the maximum number of >> >>>> >> >>>> Well, as you know the number of uart ports are different on each Samsung SoCs >> >>>> so I don't think just using maximum number of uart ports are possible for new >> >>>> exynos7 SoC at this moment. >> >>> >> >>> Thanks for the review. >> >>> The main reason for me sending this patch was so that we may be able >> >>> to re-use the serial driver on arm64 based Exynos7 too. The two >> >>> symbols mentioned above which depend on PLAT_SAMSUNG prevent this. I >> >>> initially sent a patch which changed the dependency to SERIAL_SAMSUNG >> >>> for these 2 symbols. However, Tomasz suggested that a clean-up of >> >>> these two symbols would be a better option. >> >>> >> >>> Please see the discussion of the previous version here: >> >>> https://lkml.org/lkml/2014/9/29/702 >> >>> >> >>> Can you please let me know if the previous version is acceptable ? >> >> >> >> Kukjin, can you please indicate the approach you would like me to >> >> take. Without this serial support is blocked on Exynos7. >> > >> > Gentle reminder on this. >> >> Hi Kukjin, >> > Hi Abhilash, > >> I don't mean to nag, but this another reminder to review this. > > Yeah, it's no problem for me ;) > >> Please let me know if you are too busy to have a look at this or >> require some more inputs from me. >> > Since I'm still having some objection on 2nd version, how about keeping current > config options for serial for now and changing the dependency to SERIAL_SAMSUNG? > And if required later, we can look into removal these config options later. OK, thanks. My earlier patch [1] which does this still applies cleanly on linux-next. I will request Greg to review the patch. I had a question regarding the merging of pending exynos7 patches. The clock exynos7 support will go through your tree (according to [2]) and so must the exynos7 arch/dts support [3] due to the related dependencies. As part of the arch/dts support we are enabling the samsung serial driver in arm64 defconfig. This will cause build breakages without [1] being applied. So, I assume all 3 patch-sets will go through your tree once they have been ack'ed or is there some other way ? [1] serial: samsung: Fix serial config dependencies for exynos7 https://patchwork.kernel.org/patch/4993521/ [2] GIT PULL] Samsung clock changes for 3.19 http://www.spinics.net/lists/arm-kernel/msg373962.html [3] [PATCH v7 0/7] Enable support for Samsung Exynos7 SoC http://www.spinics.net/lists/arm-kernel/msg375961.html > > Thanks, > Kukjin > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |