On 26.09.2014 13:01, Sylwester Nawrocki wrote: > Hi Tomasz, > > On 25/09/14 23:58, Tomasz Figa wrote: >> On 10.09.2014 18:37, Sylwester Nawrocki wrote: >>>> The default mux and divider clocks are specified in device tree >>>> so that the FIMC devices in Exynos4210 and Exynos4x12 SoCs are >>>> clocked from recommended clock source and with maximum supported >>>> frequency. If needed these settings could be overrode in board >>>> specific dts files, however they are in practice optimal in most >>>> cases. >>>> >>>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> >>>> --- >>>> arch/arm/boot/dts/exynos4210.dtsi | 16 ++++++++++++++++ >>>> arch/arm/boot/dts/exynos4x12.dtsi | 16 ++++++++++++++++ >>>> 2 files changed, 32 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi >>>> index 807bb5b..0969d2e 100644 >>>> --- a/arch/arm/boot/dts/exynos4210.dtsi >>>> +++ b/arch/arm/boot/dts/exynos4210.dtsi >>>> @@ -154,18 +154,30 @@ >>>> samsung,pix-limits = <4224 8192 1920 4224>; >>>> samsung,mainscaler-ext; >>>> samsung,cam-if; >>>> + assigned-clocks = <&clock CLK_MOUT_FIMC0>, >>>> + <&clock CLK_SCLK_FIMC0>; >>>> + assigned-clock-parents = <&clock CLK_SCLK_MPLL>; >>>> + assigned-clock-rates = <0>, <160000000>; >> >> I wonder whether such settings shouldn't really be set up on a per-board >> basis. >> >> As Daniel already pointed, we have cases when MPLL frequency differs >> across boards, but we might also have boards that differ in power budget >> and so having different desired operating frequencies for various IP blocks. >> >> What do you think? > > This patch provides sane default values for Exynos4210, MPLL is recommended > clock source for FIMC devices. If any other clock frequency is needed for > selected boards the clocks setup could be simply overwritten in board dts > file. Otherwise similar changes would have to be done in each board dts. I'm not concerned specifically with Exynos4210, but with placing such kind of data in common dtsi files. Notice that even on boards which have correct initialization done by firmware, this will cause the settings to be overwritten, even if the firmware sets correct, but different values, regardless of them being clock parents or rates. To me, even if this would mean duplicating some data, making this per board and present only in dts files of boards that actually need this (i.e. are known to have broken firmware) sounds more reasonable. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |