On Sat, Aug 23, 2014 at 3:59 PM, Andreas Färber <afaerber@xxxxxxx> wrote:
> Seeing a Reviewed-by, I'm recording comments from another thread so that
> they don't get forgotten:
I did remember these. Thanks for the reminder though!
> Am 25.07.2014 21:44, schrieb Ajay Kumar:
>> Add DT nodes for panel-simple "auo,b133htn01" panel.
>> Add backlight enable pin and backlight power supply for pwm-backlight.
>> Also add panel phandle needed by dp to enable display on peach_pi.
>>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs@xxxxxxxxxxx>
>> ---
>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 ++++++++++-----------------
>> 1 file changed, 10 insertions(+), 17 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> index f3ee48b..5342638 100644
>> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> @@ -28,11 +28,13 @@
>> i2c20 = "/spi@12d40000/cros-ec@0/i2c-tunnel";
>> };
>>
>> - backlight {
>> + backlight: backlight {
>> compatible = "pwm-backlight";
>> pwms = <&pwm 0 1000000 0>;
>> brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
>> default-brightness-level = <7>;
>> + enable-gpios = <&gpx2 2 0>;
>> + power-supply = <&tps65090_fet1>;
>> pinctrl-0 = <&pwm0_out>;
>> pinctrl-names = "default";
>> };
>> @@ -98,6 +100,12 @@
>> regulator-boot-on;
>> regulator-always-on;
>> };
>> +
>> + panel: panel-simple {
>
> Just "panel"? (AF)
>> + compatible = "auo,b133htn01", "simple-panel";
>
> Drop "simple-panel" (Thierry)
I will fix all these nits as per the other patch and resend along with
the driver patches.
Ajay
>> + power-supply = <&tps65090_fet6>;
>> + backlight = <&backlight>;
>> + };
>> };
>>
>> &dp {
>> @@ -111,22 +119,7 @@
>> samsung,link-rate = <0x0a>;
>> samsung,lane-count = <2>;
>> samsung,hpd-gpio = <&gpx2 6 0>;
>> -
>> - display-timings {
>> - native-mode = <&timing1>;
>> -
>> - timing1: timing@1 {
>> - clock-frequency = <150660000>;
>> - hactive = <1920>;
>> - vactive = <1080>;
>> - hfront-porch = <60>;
>> - hback-porch = <172>;
>> - hsync-len = <80>;
>> - vback-porch = <25>;
>> - vfront-porch = <10>;
>> - vsync-len = <10>;
>> - };
>> - };
>> + panel = <&panel>;
>> };
>>
>> &fimd {
>
> Regards,
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
