Andreas, On Fri, Jul 25, 2014 at 8:30 AM, Andreas Färber <afaerber@xxxxxxx> wrote: > Hi Doug, > > Am 25.07.2014 17:13, schrieb Doug Anderson: >> On Fri, Jul 25, 2014 at 8:08 AM, Doug Anderson <dianders@xxxxxxxxxxxx> wrote: >>> On Thu, Jul 24, 2014 at 10:28 PM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote: >>>> Andreas Färber wrote: >>>>> >>>>> Move it from exynos5250-cros-common.dtsi to exynos5250-snow.dts. >>>>> Spring does not need it, it uses an s5m8767 instead. >>>>> >>>>> Signed-off-by: Andreas Färber <afaerber@xxxxxxx> >>>>> --- >>>> >>>> Doug, can you have a look this series for exynos5250-chromebook? >>>> I'm not sure exynos5250-cros-common is still useful for exynos5250-spring... >>> >>> Right. The current suggestion is to rework to just duplicate things >>> and don't use exynos5250-cros-common. >> >> Oh, it actually looks like your patch series ends up there, but the >> first patch confused me. > > NP, guess you just started reading in the middle. ;) Yeah, I had this on my list to look at but ended up looking at this one first due to Kukjin's response. >> Why move just the maxim PMIC first? > > Review of the movements surely is easier this way, and it did not yet > seem a done deal that we would drop -cros-common. The merge patch nicely > shows which common parts need to be copied into spring. That's fine. I can review it this way now that I realize what's going on. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html