Hi Doug, Am 25.07.2014 17:13, schrieb Doug Anderson: > On Fri, Jul 25, 2014 at 8:08 AM, Doug Anderson <dianders@xxxxxxxxxxxx> wrote: >> On Thu, Jul 24, 2014 at 10:28 PM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote: >>> Andreas Färber wrote: >>>> >>>> Move it from exynos5250-cros-common.dtsi to exynos5250-snow.dts. >>>> Spring does not need it, it uses an s5m8767 instead. >>>> >>>> Signed-off-by: Andreas Färber <afaerber@xxxxxxx> >>>> --- >>> >>> Doug, can you have a look this series for exynos5250-chromebook? >>> I'm not sure exynos5250-cros-common is still useful for exynos5250-spring... >> >> Right. The current suggestion is to rework to just duplicate things >> and don't use exynos5250-cros-common. > > Oh, it actually looks like your patch series ends up there, but the > first patch confused me. NP, guess you just started reading in the middle. ;) > Why move just the maxim PMIC first? Review of the movements surely is easier this way, and it did not yet seem a done deal that we would drop -cros-common. The merge patch nicely shows which common parts need to be copied into spring. > Move > everything at once and be done with the common file, then do > cleanup... If everyone agrees that we want to proceed that way, we can easily squash patches 1+2. Separating is always harder. Cheers, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |