On Fri, Jul 18, 2014 at 12:31:48AM +0200, Javier Martinez Canillas wrote: > In the case of the MAX77686, the mfd, regulator and clock drivers use > subsys_initcall() instead of module_init() but I wonder which of these > really need to be initialized at subsys init call time and which one > can just be built as a module. I think you're making a frequently made mistake concerning module initialisation. Having code initialised by subsys_initcall() (or indeed any other level) does not preclude it being a module: #ifndef MODULE ... #define subsys_initcall(fn) __define_initcall(fn, 4) ... #else /* MODULE */ ... #define subsys_initcall(fn) module_init(fn) ... #endif So, subsys_initcall() automagically becomes module_init() when built as a module. There's no need to change anything here. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html