Hello, On Tue, Jul 15, 2014 at 5:59 PM, Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > Is there a reason not to add more of the max77686 configs? > > +CONFIG_RTC_DRV_MAX77686=y > +CONFIG_COMMON_CLK_MAX77686=y AFAIK for the multi-platform defconfig we should try to build as a module as many config options as possible to keep the kernel binary size to a minimum. In the case of the MAX77686, the mfd, regulator and clock drivers use subsys_initcall() instead of module_init() but I wonder which of these really need to be initialized at subsys init call time and which one can just be built as a module. The only MAX77686 driver that uses module_platform_driver() so it's initialized at device initcall time is the rtc-max77686 driver which ironically is the only MAX77686 driver that doesn't define a MODULE_DEVICE_TABLE() so the module won't be autoloaded. Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |