On Mon, Jun 16, 2014 at 5:20 PM, Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> wrote: > On 16/06/14 13:43, Tushar Behera wrote: >> On 06/09/2014 04:36 PM, Sylwester Nawrocki wrote: >>> > On 09/06/14 12:44, Tushar Behera wrote: >>>> >> IMHO, the clock entries belong here as the audss clock provider >>>> >> essentially remains same for all Exynos4 based systems. >>>> >> >>>> >> As for pin-control entry, I believe we can move them to respective SoC >>>> >> dtsi files. >>>> >> >>>> >> Does that sound okay to you? >>> > >>> > I guess that's fine, I tend to agree with you about the clocks. >>> > >> As I was going ahead with the implementation, it felt like repetition >> with the same code. Would it be acceptable to you if we go ahead with >> the earlier approach of adding both clock and pin-control entry to >> exynos4.dtsi? >> >> I can see i2c_n and spi_n adding pin-control entries in exynos4.dtsi itself. > > OK, I don't mind, I'll leave it up to the maintainers. > > -- > Regards, > Sylwester Kukjin, Any comments on this? If not, I will resend this patch based on v3.16-rc1. -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html